-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major API restructuring #319
Draft
byewokko
wants to merge
15
commits into
main
Choose a base branch
from
feature/major-api-restructuring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagement endpoints are now prefixed with /account
byewokko
added
enhancement
New feature or request
breaking change
This will introduce a breaking change
labels
Nov 16, 2023
@byewokko I'm assigned? ;-) |
Please also publish:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 This seriously breaks Auth UI and Admin UI functionality without backward compatibility. 🚨
❗ This MR will likely be split into smaller MRs. ❗
Sync merge with
Summary
/account
).-
(e.g./public/login-prologue
instead of/public/login.prologue
).Complete table of endpoint path changes
seacat-auth-endpoints-rev-2024-02.ods
APIs
Public web container (default port 3081)
/.well-known/
- standard well-known locations (OIDC)/openidconnect/
- OAuth 2.0 and OIDC API/public/
- core authentication API (login, logout, registration, lost password, cookie entry...)Private web container (default port 8900)
/account/
- Seacat Account API (change password, change email, configure login options...)/admin/
- Seacat Admin API (manage tenants, roles, credentials...)seacat:access
authorization required/nginx/
- internal nginx utilities (introspection)/asab/
- ASAB API/doc
,/oauth2-redirect.html
and/asab/v1/openapi
- Swagger docs and OpenAPI/.well-known/
,/openidconnect/
and/public/
as in the public containerTODO
GET /tenant
endpoint anymore/account/{tenant}/invite
?